Existing develop branch. I never touched scaling, but searched for it in the last half an hour, but did not find a place except the public function getFromBlurHash(string $blurhash, int $width, int $height) function (no idea what's their purpose, but I saw some couple of commits regarding the blur hash topic recently). This method is the only one that calls a scaling function Images::getScalingDimensions($width, $height, 90); in Images.php here:
The phenomena is not exclusive to my dev instance here, but also occurs on my live private instance friendica.mbbit.de also on dev: friendica.mbbit.de/photos/mare…
Might be caused by a commit after new stable 2022.12 (current stable) since the on my kassel.social instance running stable everything is (still) fine: kassel.social/photos/marek/alb…
@Roland Häder @Mihai von Glogowatz This is my fault. I deleted the test photos last night heedlessly without considering that I included them in this post -.-
Thank you so much for your valuable research. That helps a lot. Now I have a suspicion: It is related to the rotation. I opened one of the affected images in GIMP and here I see (testing portrait screenshot by the way):
…F based orient method
It's a bit confusing as there are multiple locations where images are rotated.
This PR solves the problem of portrait images being rendered distorted as landscapes by having ...
Hallo from template!
in reply to Friendica Entwickler MarekHypolite Petovan
in reply to Friendica Entwickler Marek • • •Hallo from template!
in reply to Hypolite PetovanFriendica Entwickler Marek
in reply to Hypolite Petovan • •Hallo from template!
in reply to Friendica Entwickler MarekHypolite Petovan
in reply to Friendica Entwickler Marek • • •Hallo from template!
in reply to Hypolite PetovanFriendica Entwickler Marek
in reply to Hypolite Petovan • •Existing develop branch. I never touched scaling, but searched for it in the last half an hour, but did not find a place except the
public function getFromBlurHash(string $blurhash, int $width, int $height)function (no idea what's their purpose, but I saw some couple of commits regarding the blur hash topic recently). This method is the only one that calls a scaling functionImages::getScalingDimensions($width, $height, 90);in Images.php here:github.com/friendica/friendica…
Hallo from template!
in reply to Friendica Entwickler MarekFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • •The phenomena is not exclusive to my dev instance here, but also occurs on my live private instance friendica.mbbit.de also on dev:
friendica.mbbit.de/photos/mare…
Might be caused by a commit after new stable 2022.12 (current stable) since the on my kassel.social instance running stable everything is (still) fine:
kassel.social/photos/marek/alb…
Hallo from template!
in reply to Friendica Entwickler Marekutzer [Friendica]
in reply to Friendica Entwickler Marek • • •Friendica Entwickler Marek likes this.
Hallo from template!
in reply to utzer [Friendica]Friendica Entwickler Marek
in reply to utzer [Friendica] • •utzer [Friendica] likes this.
Hallo from template!
in reply to Friendica Entwickler MarekFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • •Hypolite Petovan likes this.
Hallo from template!
Unknown parentFriendica Entwickler Marek
Unknown parent • •The problem does not occur in last stable (2022.12) but from some later commit on current develop branch.
Hallo from template!
Unknown parentFriendica Entwickler Marek
Unknown parent • •Thank you so much for your valuable research. That helps a lot. Now I have a suspicion: It is related to the rotation. I opened one of the affected images in GIMP and here I see (testing portrait screenshot by the way):
I will look in the changes
github.com/friendica/friendica…
for this.
Hallo from template!
in reply to Friendica Entwickler MarekFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • •I identified and addressed the problem. Thank you @Hank G ☑️ , @Roland Häder , @utzer ~Friendica~ , @Mihai von Glogowatz , @Hypolite Petovan , @Tio for the great support!
Pull request created:
github.com/friendica/friendica…
Fixed width and height not updated when image rotation is done by EXI… by MarekBenjamin · Pull Request #12558 · friendica/friendica
GitHubHallo from template!
in reply to Friendica Entwickler MarekFriendica Entwickler Marek
in reply to Friendica Entwickler Marek • •Hypolite Petovan likes this.