Skip to main content

Yet another photo test, should all be PORTRAIT!
Please click on any image to confirm that they are portraits
Hypolite Petovan
Hypolite Petovan  
•
@Friendica Entwickler Marek They all display distorted as landscape on my device on my node 🤣
@Friendica Entwickler Marek
This entry was edited (1 year ago)
Friendica Entwickler Marek
Friendica Entwickler Marek  
Thank you for having a look at / confirm it. I guess this is a new issue.
Hypolite Petovan
Hypolite Petovan  
•
@Friendica Entwickler Marek Is it related to new code you are working or existing code?
@Friendica Entwickler Marek
Friendica Entwickler Marek
Friendica Entwickler Marek  
Existing develop branch. I never touched scaling, but searched for it in the last half an hour, but did not find a place except the public function getFromBlurHash(string $blurhash, int $width, int $height) function (no idea what's their purpose, but I saw some couple of commits regarding the blur hash topic recently). This method is the only one that calls a scaling function Images::getScalingDimensions($width, $height, 90); in Images.php here:

https://github.com/friendica/friendica/blob/59268c600cc93591006b7f0f0e9de3a0344e7d4f/src/Object/Image.php#L785-L796
Friendica Entwickler Marek
Friendica Entwickler Marek  
The phenomena is not exclusive to my dev instance here, but also occurs on my live private instance friendica.mbbit.de also on dev:
https://friendica.mbbit.de/photos/marek/album/7363616c6554657374

Might be caused by a commit after new stable 2022.12 (current stable) since the on my kassel.social instance running stable everything is (still) fine:
https://kassel.social/photos/marek/album/7363616c6554657374
utzer [Friendica]
utzer [Friendica]  
•
@Friendica Entwickler Marek landscape thumbnails, but portrait when clicked.
@Friendica Entwickler Marek
Friendica Entwickler Marek
Friendica Entwickler Marek  
Thank you for providing the screenshots! :-) That's why I assume it is an issue in the back end when those previews are created.
Friendica Entwickler Marek
Friendica Entwickler Marek  
@Roland Häder @Mihai von Glogowatz This is my fault. I deleted the test photos last night heedlessly without considering that I included them in this post -.-
@Roland Häder
Friendica Entwickler Marek
Friendica Entwickler Marek  
What is the base version of your instance?
The problem does not occur in last stable (2022.12) but from some later commit on current develop branch.
Friendica Entwickler Marek
Friendica Entwickler Marek  
Thank you so much for your valuable research. That helps a lot. Now I have a suspicion: It is related to the rotation. I opened one of the affected images in GIMP and here I see (testing portrait screenshot by the way):



I will look in the changes
https://github.com/friendica/friendica/commit/8b3a9fc58a969a3d9202f6858d5228f3a28be1ef#diff-25183d8701208d633688677aff7f6ce0cd6b5d04065d37cda3664082323fed9bL353-L358
for this.
Friendica Entwickler Marek
Friendica Entwickler Marek  
I identified and addressed the problem. Thank you @Hank G ☑️ , @Roland Häder , @utzer ~Friendica~ , @Mihai von Glogowatz , @Hypolite Petovan , @Tio for the great support!

Pull request created:
https://github.com/friendica/friendica/pull/12558

Fixed width and height not updated when image rotation is done by EXI… by MarekBenjamin · Pull Request #12558 · friendica/friendica

…F based orient method It's a bit confusing as there are multiple locations where images are rotated. This PR solves the problem of portrait images being rendered distorted as landscapes by having ...
GitHub
@Hypolite Petovan @Roland Häder @Tio @Hank G ☑️ @utzer [Friendica]
Friendica Entwickler Marek
Friendica Entwickler Marek  
Mäh! Now, no image grid was created. :-D
⇧